-
Notifications
You must be signed in to change notification settings - Fork 0
docs: ドキュメントと設定ファイルの整合性を修正 #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| # Assumptions for Ubuntu SQLite Viewer | ||
| # Assumptions for SQLite View | ||
|
|
||
| - Target platform is Ubuntu 22.04 LTS or newer with Python >= 3.10 preinstalled. | ||
| - End users install the application on desktop environments where X11/Wayland is available for GUI rendering. | ||
| - PyQt6 wheels are acceptable for bundling within the Debian package; no system Qt dependencies are required. | ||
| - Primary target platforms are Ubuntu/Linux (primary development), Windows (confirmed working), and macOS (untested). Python >= 3.10 is required. | ||
| - End users install the application on desktop environments where X11/Wayland (Linux) or native window system (Windows/macOS) is available for GUI rendering. | ||
| - PyQt6 wheels are acceptable for bundling within the Debian package; no system Qt dependencies are required. On Windows, PyQt6 bundles all necessary dependencies. | ||
| - Users operate on local SQLite databases; remote connections are out of scope. | ||
| - Database files are expected to fit in memory for paging 1,000-row chunks; extremely large tables may require streaming in a future iteration. | ||
| - Packaging leverages native Python tooling and `dpkg-deb`; `fpm` or other third-party packagers are not required on target systems. | ||
| - Debian packaging leverages native Python tooling and `dpkg-deb`; `fpm` or other third-party packagers are not required on target systems. | ||
| - CI runs on GitHub-hosted Ubuntu runners with internet access to install Python dependencies. | ||
| - Application internationalization/localization is not required for this release; English-only UI is acceptable. | ||
| - UI is English-only. Japanese documentation (`README_ja.md`) is provided separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
実行ファイル名が
sqliteviewに統一されたのは素晴らしい改善です。一貫性をさらに高めるため、このデスクトップファイル自体の名前もsqliteview.desktopに変更し、scripts/build_deb.sh内の参照も更新することを検討してはいかがでしょうか。これにより、実行ファイル名、Debianパッケージ名、デスクトップファイル名がすべてsqliteviewで統一され、より分かりやすくなります。