Smart close: check if we're destroying the right instance#119
Open
xfra35 wants to merge 1 commit intokylefox:masterfrom
Open
Smart close: check if we're destroying the right instance#119xfra35 wants to merge 1 commit intokylefox:masterfrom
xfra35 wants to merge 1 commit intokylefox:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the plugin handles only one modal at a time, the need may arise to have one
modal:closetrigger anothermodal:openin order to implement state management. Here's an example:This doesn't play nicely with the current codebase:
$modal2shows up but stop responding afterwards (uncloseable). The reason is that thecurrentinstance gets destroyed by the first modalclose()call.This PR intends to fix that by adding a simple check before destroying the
currentinstance.NB: Unsubscribing to
keydown.modalis performed a bit earlier for the same reason:this.hide()may trigger anothermodal:open.