fix: keep ajax callbacks scoped to their originating modal#316
Open
dusan-maintains wants to merge 1 commit intokylefox:masterfrom
Open
fix: keep ajax callbacks scoped to their originating modal#316dusan-maintains wants to merge 1 commit intokylefox:masterfrom
dusan-maintains wants to merge 1 commit intokylefox:masterfrom
Conversation
Author
|
Maintainer note: this change is scoped to async race/ownership paths only (no API/default changes). If useful, I can add a minimal reproducible snippet in the PR description. |
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Current callbacks use getCurrent() / modals.pop(), which can target the wrong modal in race conditions (stacked modals or modal closed before AJAX resolution).
Changes
Test Plan
Compatibility