Skip to content

FIX dtcwt.subbands#75

Closed
xir4n wants to merge 2 commits intomainfrom
dtcwt.subbands
Closed

FIX dtcwt.subbands#75
xir4n wants to merge 2 commits intomainfrom
dtcwt.subbands

Conversation

@xir4n
Copy link
Copy Markdown
Collaborator

@xir4n xir4n commented Apr 7, 2025

closes #74

@xir4n
Copy link
Copy Markdown
Collaborator Author

xir4n commented Apr 7, 2025

example:

dtcwt = murenn.DTCWT(J=8)
boundaries = dtcwt.subbands
print(boundaries)

[0.5,
0.28173828125,
0.12158203125,
0.06005859375,
0.030029296875,
0.01513671875,
0.007568359375,
0.00390625,
0.001708984375,
0.0]

@xir4n xir4n requested a review from lostanlen April 7, 2025 23:13
@xir4n xir4n changed the title Update transform1d.py FIX dtcwt.subbands Apr 7, 2025
@lostanlen
Copy link
Copy Markdown
Contributor

Thanks. We have discussed this today. I think it would be good to add the low-pass boundary. Indeed the lowest-frequency high-pass does not have a boundary at frequency zero but at some low but nonzero frequency.

@xir4n xir4n requested a review from Copilot April 8, 2025 09:06
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

tests/test_dtcwt.py:141

  • [nitpick] Changing the parameter range for J from range(1, 10) to range(2, 10) may omit edge-case testing for J=1. Consider whether tests for J=1 are needed or if new tests should be added.
@pytest.mark.parametrize("J", list(range(2, 10)))

murenn/dtcwt/transform1d.py:223

  • The threshold value has been increased from 0.2 to 0.5; please verify that this new value aligns with the normalization applied and meets the expected behavior of the subband energy detection.
threshold = 0.5

@lostanlen
Copy link
Copy Markdown
Contributor

this PR is now stale since we have deleted the subbands

@lostanlen lostanlen closed this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FIX bug in subbands and hz_to_octs

3 participants