Closed
Conversation
Collaborator
Author
|
example: dtcwt = murenn.DTCWT(J=8)
boundaries = dtcwt.subbands
print(boundaries)[0.5, |
Contributor
|
Thanks. We have discussed this today. I think it would be good to add the low-pass boundary. Indeed the lowest-frequency high-pass does not have a boundary at frequency zero but at some low but nonzero frequency. |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
tests/test_dtcwt.py:141
- [nitpick] Changing the parameter range for J from range(1, 10) to range(2, 10) may omit edge-case testing for J=1. Consider whether tests for J=1 are needed or if new tests should be added.
@pytest.mark.parametrize("J", list(range(2, 10)))
murenn/dtcwt/transform1d.py:223
- The threshold value has been increased from 0.2 to 0.5; please verify that this new value aligns with the normalization applied and meets the expected behavior of the subband energy detection.
threshold = 0.5
Contributor
|
this PR is now stale since we have deleted the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #74