api: add skipBackgroundRequests support for MutatingPolicy and GeneratingPolicy #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for
skipBackgroundRequeststo MutatingPolicy andGeneratingPolicy so they behave the same way as ClusterPolicy.
What I changed
skipBackgroundRequestsfield to the evaluationconfiguration for both policy types
to
trueWhy this change
Right now,
skipBackgroundRequestsis available for ClusterPolicy, but not forMutatingPolicy or GeneratingPolicy. This makes it hard to use features like
mutateExistingorgenerateExistingwith background requests in a consistentway.
With this change, users can explicitly set
skipBackgroundRequests: falsewhenthey want background controller requests to be processed, while keeping the
existing default behavior unchanged.
Backward compatibility
This is fully backward compatible. Policies that don’t specify the field will
continue to skip background requests by default.
Related issue
skipBackgroundRequestsfor MutatingPolicy and GeneratingPolicy types kyverno#14852