Byteswap SmartScope.Rom.Map structure as needed when marshalling#1
Open
zeldin wants to merge 7 commits intolabnation:masterfrom
Open
Byteswap SmartScope.Rom.Map structure as needed when marshalling#1zeldin wants to merge 7 commits intolabnation:masterfrom
zeldin wants to merge 7 commits intolabnation:masterfrom
Conversation
IScope: added getter for VerticalRange IScope: added getter for AcquisitionMode
The Map structure is stored in little endian format in the FLASH. Thus, if the host is big endian, the structure needs to be byteswapped during marshalling.
Contributor
|
Thanks for this. Can you elaborate on which platform you found this fix to be necessary? I'm mostly curious to understand what you are building 😉 |
Contributor
Author
|
I'm running on Linux/PowerPC (32-bit big endian). |
louiecaulfield
force-pushed
the
master
branch
2 times, most recently
from
d9b4619 to
6fa39d1
Compare
louiecaulfield
force-pushed
the
master
branch
from
acd27a1 to
8a8ebbc
Compare
louiecaulfield
force-pushed
the
master
branch
2 times, most recently
from
6bda1e9 to
7984e5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Map structure is stored in little endian format in the FLASH.
Thus, if the host is big endian, the structure needs to be
byteswapped during marshalling.