ci: run workflows on the v4 branch, not just master#3013
Merged
Conversation
The v4 LTS maintenance branch received no CI because both workflows triggered only on master (a stale snapshot from when v4 was the default branch). Add v4 to the push and pull_request branch filters so v4 PRs and pushes are tested. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v4 LTS maintenance branch receives no CI. Both
echo.yml(Run Tests) andchecks.yml(Run checks) trigger only onmaster— a stale snapshot from when v4 was the default branch. As a result, PRs targetingv4(e.g. the recent security backport #3011) get zero automated testing and must be dispatched manually.Fix
Add
v4to thepushandpull_requestbranch filters in both workflows.Note on this PR
Because
pull_requestworkflows run from the base branch's config, this PR itself won't auto-run CI (the basev4doesn't have the trigger yet — chicken-and-egg). I've dispatched both workflows manually on this branch to validate the YAML and confirm they pass. After merge, all future v4 pushes/PRs will be tested automatically.🤖 Generated with Claude Code