Merged
Conversation
This updates test and example code to use a `_set_` prefix on setters as standard.
julianstirling
approved these changes
Jan 12, 2026
Contributor
julianstirling
left a comment
julianstirling
left a comment
There was a problem hiding this comment.
Looks good. The clarification in the docs is very clear. Thanks for this!
Contributor
|
I see that that mypy has found an unused ignore? |
I changed the name of a property setter that was deliberately the same as the getter. This reverts that change so mypy passes again.
rwb27
changed the title
_set_ prefix on property setters._set_ prefix on property setters.
Collaborator
Author
|
Thanks - that was me being overzealous, I've reverted teh offending line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates test and example code to use a
_set_prefix on setters as standard. I think this is a trivial change but follows best practice.I noticed there's now a broken unit test on Windows, which I'll fix separately. I hope the tests will still all pass in CI.