Add application configuration that propagates to Things#261
Open
julianstirling wants to merge 1 commit intomainfrom
Open
Add application configuration that propagates to Things#261julianstirling wants to merge 1 commit intomainfrom
julianstirling wants to merge 1 commit intomainfrom
Conversation
julianstirling
force-pushed
the
app-config
branch
from
d336a20 to
ce87e19
Compare
Barecheck - Code coverage reportTotal: 96.44%Your code coverage diff: 0.02% ▴ Uncovered files and lines
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an arbitrary configuration dictionary for downstream applications to use.
Context
In the OpenFlexure Microscope we have configuration specific to our application. We need to intercept the configuration validation and extract our own information. However, there is still no good way to propagate this information to individual Things.
This PR creates a place for an
application_configuration, where downstream applications can put any configuration they find useful, and make it available to each Thing in the application.No validation is performed, validation is left to downstream applications.