Fix Data Dependency and Self-Loop Handling + Refactor Core Functions#28
Merged
DanielAugusto191 merged 17 commits intomainfrom May 5, 2025
Merged
Fix Data Dependency and Self-Loop Handling + Refactor Core Functions#28DanielAugusto191 merged 17 commits intomainfrom
DanielAugusto191 merged 17 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issues encountered while executing our pass in the LLVM Test Suite and includes several functional fixes and code refactorings.
Issues Fixed
Incomplete Data and Control Dependencies
The existing implementation in
computeGatesandget_data_dependences_for(inProgramSlice.cpp) did not correctly account for all relevant edges and basic blocks when computing data and control dependencies.Incorrect Handling of Self-Loops
In cases where a basic block has a self-loop (an edge to itself), its gating instruction (typically a branch) was being included in the outlined slice function, resulting in incorrect slices.
Refactorings
isSelfContained,canRemoveandkillSlicefunctions indaedalus.cppto improve readability and maintainability.test4.c.Additions
getParentFunctiongetter to log the parent function during each iteration of function outlining.