Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34
This pull request refactors the
PathExprrepresentation to improve performance, clarity, and maintainability. The core change replaces thestd::variantandstd::shared_ptr-based implementation with a simpler, custom pointer-basedPathExprclass.This new approach simplifies the data structure, reduces dynamic memory management overhead, and makes the path expression logic more explicit.
Major Changes
Refactored
PathExprto a Custom Class: Replaced thestd::variant-basedPathExprwith a single, pointer-based class. This new class uses anenumfor type dispatching instead ofstd::visit, eliminating dynamic polymorphism and simplifying memory management. All related creation and manipulation methods (createEdgeExpr,mergePaths, etc.) have been updated.include/PHIGateAnalyzer.h,lib/PHIGateAnalyzer.cpp)Improved Performance and Determinism:
API Updates and Cleanup
ProgramSliceconstructor andoutlinemethod signatures to reflect the newPathExprinterface.include/ProgramSlice.h)std::visitpatterns. All traversal, collection, and printing logic has been consolidated into the newPathExprclass.include/PHIGateAnalyzer.h,lib/PHIGateAnalyzer.cpp)