Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant changes focused on improving the Daedalus LLVM pass infrastructure, with a particular emphasis on codebase cleanup, performance measurement, and experiment automation. The most important changes are the removal of unused function merging code, the introduction of detailed timing for pass phases, and enhancements to experiment reproducibility in the Docker environment.
Codebase cleanup and refactoring:
mergeFunctionsmethod and its references in bothProgramSlice.handProgramSlice.cpp. This streamlines the codebase and eliminates confusion about unsupported or deprecated features.ProgramSliceclass to support new construction patterns.Performance measurement and profiling:
TimerandTimerGroupobjects to measure the duration of main phases and subphases of the Daedalus pass, including outlining, merging, and simplification. Timers are conditionally activated based on LLVM's timing flags, and code blocks are wrapped withTimeRegionfor accurate profiling.Experiment automation and Docker improvements:
-w 20), and specifying all required paths and options for reproducibility. Removed the separate build of a code-size LLVM fork, as it is no longer necessary.Minor code and documentation updates:
mergeTotomergedFunctions) for clarity in function parameters and documentation.Structural refactoring:
outlinePhaseandmergePhase), improving readability and maintainability.These changes collectively enhance the maintainability, observability, and reproducibility of the Daedalus project.