You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request adds support for the new extended SegWit transaction format. The new structure can be seen in the Bitcoin source code here.
In addition, this pull changes how block version numbers are handled. Previously, all known version combinations were explicitly white-listed. The version field has been somewhat re-purposed by BIP 9 for soft/hard fork signaling. I've changed the version code to handle this, so every bit combination won't need to be explicitly be checked for.
One housekeeping note: I've removed the StyleCop reference from the project since I don't have this.
So we rebuilt the .dll incorporating the two pull requests here, but still hit error:
File: blk01133.dat. Transferring data: 81%
AN ERROR OCCURRED:
System.ArgumentOutOfRangeException: Non-negative number required.
Parameter name: count
at System.IO.BinaryReader.ReadBytes(Int32 count)
at BitcoinBlockchain.Parser.BlockMemoryStreamReader.ReadBytes(Int32 count)
at BitcoinBlockchain.Parser.BlockchainParser.ParseTransactionOutput(BlockMemoryStreamReader blockMemoryStreamReader)
at BitcoinBlockchain.Parser.BlockchainParser.ParseTransaction(BlockMemoryStreamReader blockMemoryStreamReader)
at BitcoinBlockchain.Parser.BlockchainParser.InternalParseBlockchainFile(String blockchainFileName, BlockMemoryStreamReader blockMemoryStreamReader)
at BitcoinBlockchain.Parser.BlockchainParser.ParseBlockchainFile(String blockchainFileName, BinaryReader binaryReader)
at BitcoinBlockchain.Parser.BlockchainParser.d__22.MoveNext()
at BitcoinBlockchain.Parser.BlockchainParser.d__9.MoveNext()
at BitcoinDatabaseGenerator.DatabaseGenerator.d__21.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at BitcoinDatabaseGenerator.DatabaseGenerator.d__21.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at BitcoinDatabaseGenerator.DatabaseGenerator.d__8.MoveNext()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the new extended SegWit transaction format. The new structure can be seen in the Bitcoin source code here.
In addition, this pull changes how block version numbers are handled. Previously, all known version combinations were explicitly white-listed. The version field has been somewhat re-purposed by BIP 9 for soft/hard fork signaling. I've changed the version code to handle this, so every bit combination won't need to be explicitly be checked for.
One housekeeping note: I've removed the StyleCop reference from the project since I don't have this.
I used this branch to fully process the Bitcoin blockchain with BitcoinDatabaseGenerator