Optimize CI workflows: add caching, reduce redundant steps#1
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Optimize CI workflows: add caching, reduce redundant steps#1devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
artifact.yaml: - sdist: replace curl rustup with dtolnay/rust-toolchain action - sdist: add Swatinem/rust-cache for Cargo registry/target caching - sdist: add pip caching via actions/setup-python cache option - sdist: combine pip install steps (one resolution pass instead of two) - sdist: combine integration test steps to reduce step overhead - macos_aarch64: add Swatinem/rust-cache for Cargo caching - macos_aarch64: combine integration test steps (removes repeated venv activation) - macos_universal2_aarch64: add Swatinem/rust-cache for Cargo caching - macos_universal2_aarch64: combine integration test steps - windows_amd64: add Swatinem/rust-cache and pip caching - windows_aarch64: add Swatinem/rust-cache and pip caching unusual.yaml: - Update actions/setup-python v5 to v6 with pip caching - Replace curl rustup with dtolnay/rust-toolchain action - Add Swatinem/rust-cache for Cargo registry/target caching - Combine pip install steps (one resolution pass instead of two) - Combine integration test steps into single step - Move checkout before toolchain setup for proper cache key resolution Co-Authored-By: laloesparza458 <laloesparza458@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds dependency caching and reduces step overhead across
artifact.yamlandunusual.yamlCI workflows. No changes to build logic, test commands, or artifacts produced.Caching additions:
Swatinem/rust-cache@v2added to all jobs that install Rust directly (sdist, macos_aarch64, macos_universal2, windows_amd64, windows_aarch64, unusual). Skipped for container-based jobs (manylinux, musllinux) where caching wouldn't persist.cache: 'pip'added toactions/setup-pythonin sdist, windows_amd64, windows_aarch64, and unusual jobs.Redundancy removal:
pip installcalls consolidated into one (test/integration deps installed upfront alongside maturin, removing a second pip resolution pass).source .venv/bin/activate).Toolchain modernization (unusual.yaml):
actions/setup-pythonupdated from v5 → v6.curl https://sh.rustup.rsreplaced withdtolnay/rust-toolchain@master(removes need for manualPATHprepend in build step).Step reordering:
actions/checkoutmoved earlier in sdist and unusual jobs so cache actions (rust-cache,setup-pythonpip cache) can readCargo.lockandrequirements*.txtfor cache key computation.Review & Testing Checklist for Human
unusual.yamlbuild step works without explicitPATH="$HOME/.cargo/bin:$PATH"—dtolnay/rust-toolchainshould add cargo toGITHUB_PATHautomatically, but this is a behavioral change. Trigger the unusual workflow and confirm thematurin buildstep findscargo.Swatinem/rust-cacheworks onwindows_aarch64— Rust is installed via manual PowerShell script, andCARGO_HOMEis set viaGITHUB_ENV(available in subsequent steps). Confirm the cache step finds the cargo registry.Notes
&) since thehttptest starts a daemon on a fixed port that could conflict with other tests.cache-on-failure: trueoption on rust-cache ensures partial compilation results are cached even on build failures, improving retry speed.Link to Devin session: https://app.devin.ai/sessions/d3a95b8122444b47a6baa069678ebb49
Requested by: @lalo458