Open
Conversation
- Centralize the XHR header logic into the transport itself since it's needed by all the requests, removing the need of the individual `transformRequest` calls. - Remove `request.basic` since it can be represented as a plain object. - Instead of using `instanceof` we check if generated requests contains the desired properties. - Remove the `Request` constructor since it wasn't doing anything and was introducing an extra level of indirection and used a JSDoc @typedef instead. - Simplified the way XML templates are interpolated in the requests.
Owner
There was a problem hiding this comment.
I think I probably wrote this for the case when we get an options without props (we really shouldn't?) but I think the template might require props?
Author
There was a problem hiding this comment.
Handlebars #each is smart enough. Shouldn't matter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
transformRequestcalls.request.basicsince it can be represented as a plain object.instanceofwe check if generated requests contains the desired properties.Requestconstructor since it wasn't doing anything and was introducing an extra level of indirection and used a JSDoc@typedefinstead.