This repository was archived by the owner on Mar 13, 2026. It is now read-only.
Draft
Conversation
cb771d8 to
01541fb
Compare
|
@igamigo what is missing to merge this?> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a cli option
--send-to-proverto enable sending proofs to SHARP through thecairo-sharpcli (you will need this installed)One caveat of using
cairo-sharpto send to SHARP is that it can only work with cairo programs, not contracts, so we need to give it a cairo program and it will compile, run, and send to the prover. All this is painfully slow, on my regular laptop takes at least 10 seconds for our simple fibonacci example.Additionally we have 2 problems
end_blockorcommitso no way to pool them for sendingcairo-sharpwill block the ABCI thread for it and thus block consensus workTo address this problems the ABCI thread on initialization spawns another thread that will do the following
deliver_txcommitto process transactions (send to prover)