Skip to content

feat(tally): add local write fixture enrollment#43

Merged
lamemustafa merged 5 commits into
masterfrom
tapish-codex/feat/tally-write-fixture-enrollment-v1
Jul 22, 2026
Merged

feat(tally): add local write fixture enrollment#43
lamemustafa merged 5 commits into
masterfrom
tapish-codex/feat/tally-write-fixture-enrollment-v1

Conversation

@lamemustafa

Copy link
Copy Markdown
Owner

Summary

  • Adds a local-only, revocable synthetic write-canary fixture enrollment gate.
  • Requires a fresh reviewed probe, a persisted GUID-bearing company pin, and three explicit safeguards.
  • Keeps write capability Unknown; enrollment, status, and revocation issue zero Tally requests and zero Tally writes.

Validation

  • corepack pnpm build
  • cargo test --locked --manifest-path src-tauri/Cargo.toml -p bridge (203 passed)
  • cargo check --locked --manifest-path src-tauri/Cargo.toml -p bridge
  • sealed compatibility gate

Migration and rollback

Migration 0013 adds immutable local enrollment and revocation evidence. The change is additive; rollback is to deploy the previous app version without deleting the local migration data. Revocation is append-only and does not alter Tally.

Security impact

No raw Tally data, company names, GUIDs, fixture content, backup locations, or free text are stored in the new evidence tables. This PR adds no transport call and does not claim Tally write support.

Review checklist

@lamemustafa
lamemustafa marked this pull request as ready for review July 22, 2026 02:45
@lamemustafa

Copy link
Copy Markdown
Owner Author

@codex review\n\nPlease focus on local-only Tally safety: no Tally I/O, immutable enrollment/revocation evidence, review-token ordering, privacy, and truthful operator states.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee3431dc50

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/src/db/tally_mirror.rs
Comment thread src-tauri/src/commands.rs
@lamemustafa

Copy link
Copy Markdown
Owner Author

@codex review\n\nPlease re-review 5e9e94c, specifically latest-revocation ordering after clock rollback and the committed-status handling for local revocation.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e9e94c08b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/src/db/tally_mirror.rs
@lamemustafa

Copy link
Copy Markdown
Owner Author

@codex review\n\nPlease review 54fcef7. Focus on the explicit durable revocation event sequence and clock-rollback ordering after every enrollment is revoked.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 54fcef7981

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src-tauri/src/db/migrations/0013_tally_write_fixture_enrollment.sql Outdated
@lamemustafa

Copy link
Copy Markdown
Owner Author

@codex review\n\nPlease review 2a18568, especially the additive v13-to-v14 migration, durable event sequencing, migration idempotence, and no-Tally-I/O boundary.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a1856828b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lamemustafa

Copy link
Copy Markdown
Owner Author

@codex review

Please review b4419aa. Focus on the dual v14 migration path for both legacy v13 schemas, no-Tally-I/O preservation, compatibility-surface sealing, and the isolated Windows simulator-test reliability fix.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: b4419aacdc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lamemustafa
lamemustafa merged commit bc7ec64 into master Jul 22, 2026
9 checks passed
@lamemustafa
lamemustafa deleted the tapish-codex/feat/tally-write-fixture-enrollment-v1 branch July 22, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant