agent: user-facing text through i18n keys, a hardcoded string is found too late - #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
llm-i18nbranch mixed three things: the localisation guidance, amake fmttarget with a
pre-commithook, and a 16-file markdown rewrap. This is theguidance alone.
Restructured to match the layout from #74 — a rule file under
shared/.claude/rules/with a row in the index — instead of landing in thisrepo's own
AGENTS.md, which is about working in this repo, not about buildingapplications. Rewritten in the same voice as the other rules: the reason first,
the bullet soup cut down, British spelling like
behaviourincommit-messages.md.Unconditional, no
paths:frontmatter: the trigger is writing a user-facingstring, not touching a particular file, and the default it overrides — type the
English in — happens before any path is known.
Left on
llm-i18n:make fmtand thepre-commithook. Separate topic, and themass rewrap is coupled to them — without it the first commit touching any
markdown file rewraps the whole thing. Say the word and that goes up as its own
PR.