fix(frontend): anchor alert notifications flush to bottom corner#14027
Conversation
Alerts rendered with an 80px gap below them because .app-div used bottom-20, a leftover clearance for a bottom-left trigger removed since PR #11636. Nothing anchors bottom-left anymore (canvas controls are bottom-center), so align with the Playground alert mount (bottom-4 left-4) for a consistent flush corner.
WalkthroughThe ChangesApp positioning
Estimated code review effort: 1 (Trivial) | ~2 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Test Coverage AdvisorNo source changes detected without accompanying tests. Thanks for keeping coverage up! 🎉
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.11.0 #14027 +/- ##
==================================================
- Coverage 59.99% 59.89% -0.10%
==================================================
Files 2389 2390 +1
Lines 230242 230279 +37
Branches 34463 34534 +71
==================================================
- Hits 138125 137920 -205
- Misses 90501 90743 +242
Partials 1616 1616
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
Error/notice/success alerts floated ~80px above the bottom-left corner, leaving a large empty gap beneath them. The global alert container (
.app-divinapplies.css) usedbottom-20 left-5; this changes it tobottom-4 left-4so alerts sit flush in the corner.Why
bottom-20was introduced in #11636 (Langflow Assistant panel) as clearance for a bottom-left trigger that no longer exists — canvas controls arebottom-centerand the assistant is a side panel, so nothing anchors bottom-left today. The offset survived as dead space.bottom-4 left-4matches the Playground page's own alert mount (fixed bottom-4 left-4insrc/pages/Playground/index.tsx), so both alert surfaces now share the same corner placement.Scope / blast radius
.app-divhas exactly one consumer: theAlertDisplayAreawrapper inAppWrapperPage. No other element uses the class, and no floating UI occupies the bottom-left corner, so there is no overlap risk.Validation
npx jest src/alerts— 4/4 pass.app-divusage; canvas controls confirmedbottom-centerScreenshots
before

After

Summary by CodeRabbit