Skip to content

feat(feature-parity) LF <> LFX Services Layer Tiering & Separation#14031

Open
dkaushik94 wants to merge 3 commits into
refactor/orm-models-to-lfxfrom
lfx-services-migration
Open

feat(feature-parity) LF <> LFX Services Layer Tiering & Separation#14031
dkaushik94 wants to merge 3 commits into
refactor/orm-models-to-lfxfrom
lfx-services-migration

Conversation

@dkaushik94

Copy link
Copy Markdown
Member

TBD

…nd VariableService to LFX service discovery routine to return service objects, and not None. Internal method calls still call noop, but avoids disgraceful errors such as AttributeError(s).
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • release-.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a8e8c444-1695-4080-979e-1ee68a994aaa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch lfx-services-migration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Test Coverage Advisor

No source changes detected without accompanying tests. Thanks for keeping coverage up! 🎉

Advisory check only — never blocks merge.

@dkaushik94 dkaushik94 force-pushed the lfx-services-migration branch from d1ceb1c to 69bad2f Compare July 13, 2026 17:06
@github-actions

Copy link
Copy Markdown
Contributor

Migration Validation Passed

All migrations follow the Expand-Contract pattern correctly.

@github-actions

Copy link
Copy Markdown
Contributor

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 44%
44.71% (60951/136324) 69.59% (8343/11988) 43.19% (1381/3197)

Unit Test Results

Tests Skipped Failures Errors Time
5153 0 💤 0 ❌ 0 🔥 20m 11s ⏱️

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.20%. Comparing base (8023291) to head (69bad2f).

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           refactor/orm-models-to-lfx   #14031      +/-   ##
==============================================================
+ Coverage                       59.17%   59.20%   +0.02%     
==============================================================
  Files                            2372     2372              
  Lines                          226897   226846      -51     
  Branches                        32310    34140    +1830     
==============================================================
+ Hits                           134267   134299      +32     
+ Misses                          91021    90939      -82     
+ Partials                         1609     1608       -1     
Flag Coverage Δ
frontend 58.65% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...backend/base/langflow/services/database/service.py 70.28% <ø> (-0.07%) ⬇️
src/backend/base/langflow/services/factory.py 83.05% <ø> (-1.08%) ⬇️
src/backend/base/langflow/services/schema.py 100.00% <ø> (ø)
src/backend/base/langflow/services/utils.py 86.40% <ø> (ø)
src/lfx/src/lfx/schema/image.py 54.83% <ø> (ø)
src/lfx/src/lfx/services/base.py 100.00% <ø> (ø)
src/lfx/src/lfx/services/database/service.py 100.00% <ø> (ø)
src/lfx/src/lfx/services/deps.py 77.38% <ø> (+9.45%) ⬆️
src/lfx/src/lfx/services/initialize.py 0.00% <ø> (ø)
src/lfx/src/lfx/services/interfaces.py 100.00% <ø> (ø)
... and 3 more

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant