fix(frontend): stop assistant 'New' pill from shifting on hover#14035
Conversation
The discovery pill animated scale-90 to scale-100 with transition-all, so the pill text visibly slid outward while growing on hover and read as the whole canvas controls bar wiggling. The pill is absolutely positioned, so the movement was purely the scale transform. Fade the pill with transition-opacity only; no size or position animation.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe assistant discovery pill now animates visibility through opacity only, removing its previous scale transitions while preserving onboarding and hover visibility logic. ChangesAssistant discovery pill
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.11.0 #14035 +/- ##
==================================================
- Coverage 59.99% 59.88% -0.11%
==================================================
Files 2389 2390 +1
Lines 230242 230282 +40
Branches 34463 34478 +15
==================================================
- Hits 138125 137897 -228
- Misses 90501 90769 +268
Partials 1616 1616
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Hovering the assistant button in the canvas controls bar made the "New" discovery pill visibly shift: it animated
scale-90 → scale-100withtransition-all, so the pill text slid outward while growing and read as the whole controls bar wiggling.Fix
The pill is absolutely positioned, so all perceived movement came from the scale transform — not real layout. This drops the scale animation and fades the pill in place:
transition-all→transition-opacityscale-90/scale-100from both the onboarding-pinned and hover statesHover states no longer change size or position of anything in the bar.
Validation
npx jest src/components/core/canvasControlsComponent— 71/71 passSummary by CodeRabbit