fix(docker): remove broken npm self-upgrade#14052
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Dockerfile removes global ChangesDocker Node installation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (8 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Test Coverage AdvisorNo source changes detected without accompanying tests. Thanks for keeping coverage up! 🎉
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.10.3 #14052 +/- ##
==================================================
+ Coverage 58.55% 58.65% +0.09%
==================================================
Files 2306 2308 +2
Lines 221006 221075 +69
Branches 34264 32450 -1814
==================================================
+ Hits 129411 129668 +257
+ Misses 90109 89922 -187
+ Partials 1486 1485 -1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Summary
npm install -g npm@latestfrom the Docker builder and runtime stagesrelease-1.11.0DockerfileWhy
The Docker build now fails because npm 12 requires Node.js
^22.22.2, while the builder stage pins Node.js 22.14.0. Node.js 22.14.0 already bundles npm 10.9.2, so the self-upgrade is unnecessary and makes the build depend on a moving incompatible npm release.Observed failure: https://github.com/langflow-ai/langflow/actions/runs/29280281726/job/86919655324
Validation
ghcr.io/astral-sh/uv:python3.14-trixie-slimv22.14.0and bundled npm10.9.2run successfully without the self-upgradegit diff --checkSummary by CodeRabbit