Skip to content

fix(docker): remove broken npm self-upgrade#14052

Merged
erichare merged 1 commit into
release-1.10.3from
fix/docker-npm-self-upgrade-release-1.10.3
Jul 13, 2026
Merged

fix(docker): remove broken npm self-upgrade#14052
erichare merged 1 commit into
release-1.10.3from
fix/docker-npm-self-upgrade-release-1.10.3

Conversation

@erichare

@erichare erichare commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove npm install -g npm@latest from the Docker builder and runtime stages
  • keep the npm version bundled with Node.js, matching the current release-1.11.0 Dockerfile

Why

The Docker build now fails because npm 12 requires Node.js ^22.22.2, while the builder stage pins Node.js 22.14.0. Node.js 22.14.0 already bundles npm 10.9.2, so the self-upgrade is unnecessary and makes the build depend on a moving incompatible npm release.

Observed failure: https://github.com/langflow-ai/langflow/actions/runs/29280281726/job/86919655324

Validation

  • reproduced the builder-stage Node.js install in ghcr.io/astral-sh/uv:python3.14-trixie-slim
  • confirmed Node.js v22.14.0 and bundled npm 10.9.2 run successfully without the self-upgrade
  • git diff --check

Summary by CodeRabbit

  • Chores
    • Simplified the container build process by removing unnecessary global npm upgrades.
    • Continued using the npm version bundled with the installed Node.js runtime.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1ec590ca-d1bd-43f1-8281-d93fd6699fae

📥 Commits

Reviewing files that changed from the base of the PR and between 2433e87 and 09352a5.

📒 Files selected for processing (1)
  • docker/build_and_push.Dockerfile

Walkthrough

The Dockerfile removes global npm@latest installation from both builder and runtime Node.js setup sequences.

Changes

Docker Node installation

Layer / File(s) Summary
Remove global npm upgrade commands
docker/build_and_push.Dockerfile
The builder and runtime stages now stop after extracting Node.js instead of installing npm@latest globally.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: bug

Suggested reviewers: adam-aghili, ogabrielluiz, vjgit96, cristhianzl, jkavia


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Test Coverage For New Implementations ❌ Error The PR changes only docker/build_and_push.Dockerfile; no test files were added or updated to cover the Docker build fix. Add a regression test or CI build check for the Dockerfile change, e.g. verify the image builds without npm self-upgrade.
✅ Passed checks (8 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: removing the broken npm self-upgrade from the Docker build.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Test Quality And Coverage ✅ Passed PASS: Dockerfile changes trigger CI’s test-docker job, which builds the image and verifies the container runs and reports the expected version.
Test File Naming And Structure ✅ Passed PR only changes docker/build_and_push.Dockerfile; no test files were added or modified, so the test-file naming/structure check is not applicable.
Excessive Mock Usage Warning ✅ Passed PR only changes docker/build_and_push.Dockerfile; no test files were modified, so the mock-usage warning check is not applicable.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/docker-npm-self-upgrade-release-1.10.3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Jul 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Test Coverage Advisor

No source changes detected without accompanying tests. Thanks for keeping coverage up! 🎉

Advisory check only — never blocks merge.

@github-actions github-actions Bot added bug Something isn't working and removed bug Something isn't working labels Jul 13, 2026
@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.65%. Comparing base (2433e87) to head (09352a5).
⚠️ Report is 1 commits behind head on release-1.10.3.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-1.10.3   #14052      +/-   ##
==================================================
+ Coverage           58.55%   58.65%   +0.09%     
==================================================
  Files                2306     2308       +2     
  Lines              221006   221075      +69     
  Branches            34264    32450    -1814     
==================================================
+ Hits               129411   129668     +257     
+ Misses              90109    89922     -187     
+ Partials             1486     1485       -1     
Flag Coverage Δ
backend 65.83% <ø> (-0.09%) ⬇️
frontend 57.81% <ø> (+0.16%) ⬆️
lfx 54.65% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 69 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 43%
43.54% (58072/133362) 69.2% (7883/11391) 41.56% (1298/3123)

Unit Test Results

Tests Skipped Failures Errors Time
4978 0 💤 0 ❌ 0 🔥 12m 24s ⏱️

@erichare erichare merged commit 61d6490 into release-1.10.3 Jul 13, 2026
110 of 111 checks passed
@erichare erichare deleted the fix/docker-npm-self-upgrade-release-1.10.3 branch July 13, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant