Skip to content

feat(api): update API spec from langfuse/langfuse c661b97 - #1815

Closed
langfuse-bot wants to merge 1 commit into
mainfrom
api-spec-bot-c661b97-31807789167-1
Closed

feat(api): update API spec from langfuse/langfuse c661b97#1815
langfuse-bot wants to merge 1 commit into
mainfrom
api-spec-bot-c661b97-31807789167-1

Conversation

@langfuse-bot

@langfuse-bot langfuse-bot commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Greptile Summary

The PR regenerates the API client from an updated specification, adding observation filtering by session and documenting new backend contracts. It also removes score endpoint deprecation warnings even though those methods continue to use the v2 API.

  • Adds session_id filtering to synchronous and asynchronous observation-list clients.
  • Documents semantic-root filtering for metrics and evaluation rules.
  • Updates comment-author and SCIM password contract descriptions.
  • Removes v4 compatibility guidance from legacy v2 score retrieval methods.

Confidence Score: 4/5

The PR appears safe to merge, but its score-client documentation should retain the non-blocking warning that the underlying v2 endpoints are unavailable on Langfuse v4.

The functional session-filter wiring is consistent across synchronous and asynchronous clients, while the sole accepted concern is misleading documentation around unchanged v2 score endpoint calls.

Files Needing Attention: langfuse/api/scores/client.py and langfuse/api/scores/raw_client.py

Prompt To Fix All With AI
### Issue 1
langfuse/api/scores/client.py:164
**Removed v4 compatibility warning**

These methods still delegate to the v2 score endpoints, but the regenerated documentation removes the warning that they are unavailable on Langfuse v4 and no longer directs affected users to the supported v3 API, leading them to select methods that return an HTTP error.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile

Context used:

@github-actions

Copy link
Copy Markdown

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — this is an auto-generated API client update (Fern) with only docstring/type additions, no logic changes.

What was reviewed: the new optional session_id param on observations.get_many (correctly threaded through to raw client params/serialization), the new isRootObservation boolean filter dimension added consistently across observations/metrics docstrings and unstable evaluation-rule-filter docs, and the removal of stale "deprecated" notices on scores.get_many/get_by_id (docstring-only, no behavior change). All changes are additive or documentation-only; no request/response handling logic was altered.

Extended reasoning...

Overview

This PR is an auto-generated update of the Langfuse Python API client (Fern-generated) reflecting upstream API spec changes from langfuse/langfuse commit c661b97. It touches comments, metrics, observations, scim, scores, and unstable evaluation-rule-filter modules. Changes fall into three categories: (1) docstring clarifications (comment author membership requirement, SCIM password field semantics, isRootObservation semantics), (2) a new optional session_id query parameter added to ObservationsClient.get_many/raw client (correctly wired into both sync and async paths and the request params dict), and (3) removal of stale deprecation notices from scores.get_many and scores.get_by_id docstrings.

Security risks

None. No changes to auth, request signing, credential handling, or serialization logic. The SCIM password field docstring change clarifies that the field was already ignored server-side — this PR only updates the client-side docstring to match, it does not change any client behavior.

Level of scrutiny

Low. This is a mechanical, auto-generated client update mirroring an upstream OpenAPI/Fern spec change. The diff is dominated by docstring text repeated across sync/async and raw/wrapped variants of the same methods. The one functional addition (session_id param) follows the exact existing pattern for other filter params (e.g. user_id) and is applied consistently across all four call-site variants.

Other factors

No CODEOWNERS-restricted paths are touched (this is the generated langfuse/api directory). No outstanding review comments exist on this PR — the only prior timeline entry is the automated @claude review trigger. The bug-hunting pass found no issues, and manual inspection confirms the new parameter is threaded through correctly with no missed call site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant