feat(api): update API spec from langfuse/langfuse c661b97 - #1815
feat(api): update API spec from langfuse/langfuse c661b97#1815langfuse-bot wants to merge 1 commit into
Conversation
|
@claude review |
There was a problem hiding this comment.
LGTM — this is an auto-generated API client update (Fern) with only docstring/type additions, no logic changes.
What was reviewed: the new optional session_id param on observations.get_many (correctly threaded through to raw client params/serialization), the new isRootObservation boolean filter dimension added consistently across observations/metrics docstrings and unstable evaluation-rule-filter docs, and the removal of stale "deprecated" notices on scores.get_many/get_by_id (docstring-only, no behavior change). All changes are additive or documentation-only; no request/response handling logic was altered.
Extended reasoning...
Overview
This PR is an auto-generated update of the Langfuse Python API client (Fern-generated) reflecting upstream API spec changes from langfuse/langfuse commit c661b97. It touches comments, metrics, observations, scim, scores, and unstable evaluation-rule-filter modules. Changes fall into three categories: (1) docstring clarifications (comment author membership requirement, SCIM password field semantics, isRootObservation semantics), (2) a new optional session_id query parameter added to ObservationsClient.get_many/raw client (correctly wired into both sync and async paths and the request params dict), and (3) removal of stale deprecation notices from scores.get_many and scores.get_by_id docstrings.
Security risks
None. No changes to auth, request signing, credential handling, or serialization logic. The SCIM password field docstring change clarifies that the field was already ignored server-side — this PR only updates the client-side docstring to match, it does not change any client behavior.
Level of scrutiny
Low. This is a mechanical, auto-generated client update mirroring an upstream OpenAPI/Fern spec change. The diff is dominated by docstring text repeated across sync/async and raw/wrapped variants of the same methods. The one functional addition (session_id param) follows the exact existing pattern for other filter params (e.g. user_id) and is applied consistently across all four call-site variants.
Other factors
No CODEOWNERS-restricted paths are touched (this is the generated langfuse/api directory). No outstanding review comments exist on this PR — the only prior timeline entry is the automated @claude review trigger. The bug-hunting pass found no issues, and manual inspection confirms the new parameter is threaded through correctly with no missed call site.
Greptile Summary
The PR regenerates the API client from an updated specification, adding observation filtering by session and documenting new backend contracts. It also removes score endpoint deprecation warnings even though those methods continue to use the v2 API.
session_idfiltering to synchronous and asynchronous observation-list clients.Confidence Score: 4/5
The PR appears safe to merge, but its score-client documentation should retain the non-blocking warning that the underlying v2 endpoints are unavailable on Langfuse v4.
The functional session-filter wiring is consistent across synchronous and asynchronous clients, while the sole accepted concern is misleading documentation around unchanged v2 score endpoint calls.
Files Needing Attention: langfuse/api/scores/client.py and langfuse/api/scores/raw_client.py
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile
Context used: