refactor: batch update environment variable documentation based on latest code#721
Merged
refactor: batch update environment variable documentation based on latest code#721
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
laipz8200
requested changes
Mar 30, 2026
JohnJyong
reviewed
Mar 30, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Documentation Updates 1 document(s) were updated by changes in this PR: REDIS_MAX_CONNECTIONS Validation Error in Dify v1.13.1View Changes@@ -1,4 +1,6 @@
### REDIS_MAX_CONNECTIONS validation error in v1.13.1
+
+> **Resolved in v1.13.2.** If you are running Dify v1.13.2 or later, this issue is already fixed and no workaround is needed. The information below applies only to users still running v1.13.1 or earlier.
When [upgrading from Dify 1.13.0 to 1.13.1](https://github.com/langgenius/dify/issues/33592), containers may fail to start with this error:
@@ -10,7 +12,7 @@
[This affects both upgrades and fresh installations using the default `.env.example` file](https://github.com/langgenius/dify/issues/33614).
-**Solution**: Add this line to your `.env` file:
+**Workaround (v1.13.1 only)**: Add this line to your `.env` file:
```
REDIS_MAX_CONNECTIONS=10
@@ -25,6 +27,6 @@
**Root cause**: Version 1.13.1 [introduced the REDIS_MAX_CONNECTIONS configuration](https://github.com/langgenius/dify/pull/32935) to [address Redis connection exhaustion issues](https://github.com/langgenius/dify/issues/31603). The [docker-compose.yaml file passes an empty string when this variable is unset](https://github.com/langgenius/dify/blob/bbe975c6bca3e3afb20de217deb67c0920b2bd6d/docker/docker-compose.yaml#L93), which Pydantic cannot parse as an integer. [Commenting out or removing the variable doesn't work](https://github.com/langgenius/dify/issues/33592) due to the docker-compose configuration.
-**Permanent fix**: [A fix was merged on March 18, 2026](https://github.com/langgenius/dify/pull/33619) that [allows empty strings to be treated as None](https://github.com/langgenius/dify/blob/bbe975c6bca3e3afb20de217deb67c0920b2bd6d/api/configs/middleware/cache/redis_config.py#L120-L128). Version 1.13.2 (released on March 18, 2026) includes the fix. Users on v1.13.1 should upgrade to v1.13.2 or later.
+**Permanent fix**: [A fix was merged on March 18, 2026](https://github.com/langgenius/dify/pull/33619) that [allows empty strings to be treated as None](https://github.com/langgenius/dify/blob/bbe975c6bca3e3afb20de217deb67c0920b2bd6d/api/configs/middleware/cache/redis_config.py#L120-L128). Version 1.13.2 (released on March 18, 2026) includes the fix. Users on v1.13.1 should upgrade to v1.13.2 or later. **Status: Resolved.**
-**About REDIS_MAX_CONNECTIONS**: This optional setting [limits the total connections in Redis connection pools](https://github.com/langgenius/dify/blob/bbe975c6bca3e3afb20de217deb67c0920b2bd6d/api/configs/middleware/cache/redis_config.py#L115-L118) across [all deployment modes](https://github.com/langgenius/dify/blob/bbe975c6bca3e3afb20de217deb67c0920b2bd6d/api/extensions/ext_redis.py) (standalone, Sentinel, Cluster, PubSub). [The default of 10 connections per pool](https://github.com/langgenius/dify/issues/33592) is reasonable for most deployments.
+**About REDIS_MAX_CONNECTIONS**: This fully optional setting [limits the total connections in Redis connection pools](https://github.com/langgenius/dify/blob/bbe975c6bca3e3afb20de217deb67c0920b2bd6d/api/configs/middleware/cache/redis_config.py#L115-L118) across [all deployment modes](https://github.com/langgenius/dify/blob/bbe975c6bca3e3afb20de217deb67c0920b2bd6d/api/extensions/ext_redis.py) (standalone, Sentinel, Cluster, PubSub). In v1.13.2 and later, leaving this variable unset (or empty) is valid — the system correctly treats an empty value as "use the Redis client library default connection pool size". Set it to a specific integer only if you need to cap the pool size to match your Redis server's `maxclients` setting.How did I do? Any feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.