Fix/OpenAI streaming usage#1798
Open
Arui1122 wants to merge 2 commits intolanggenius:mainfrom
Open
Conversation
Arui1122
commented
Oct 1, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes token counting issues for OpenAI-compatible APIs when using streaming mode by implementing request usage data collection and adding proper stream options configuration.
Key changes:
- Overrides the
_generatemethod to request usage data in streaming mode viastream_options - Adds comprehensive OpenAI-compatible API handling with proper headers, authentication, and response formatting
- Updates the manifest version to reflect the fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| models/openai_api_compatible/models/llm/llm.py | Implements custom _generate method with streaming usage data collection and complete OpenAI API compatibility |
| models/openai_api_compatible/manifest.yaml | Bumps version from 0.0.22 to 0.0.23 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues or Context
Fixes token counting issue for OpenAI-compatible APIs in streaming mode.
OpenAI-compatible providers (like LiteLLM) do not return token usage by default in streaming responses. This causes Dify to fall back to token estimation instead of using the actual count from the provider.
This PR contains Changes to Non-Plugin
This PR contains Changes to Non-LLM Models Plugin
This PR contains Changes to LLM Models Plugin
My Changes Affect Message Flow Handling (System Messages and User→Assistant Turn-Taking)
My Changes Affect Tool Interaction Flow (Multi-Round Usage and Output Handling, for both Agent App and Agent Node)
My Changes Affect Multimodal Input Handling (Images, PDFs, Audio, Video, etc.)
My Changes Affect Multimodal Output Generation (Images, Audio, Video, etc.)
My Changes Affect Structured Output Format (JSON, XML, etc.)
My Changes Affect Token Consumption Metrics
My Changes Affect Other LLM Functionalities (Reasoning Process, Grounding, Prompt Caching, etc.)
Other Changes (Add New Models, Fix Model Parameters etc.)
Version Control
VersionField, Not in Meta Section)Dify Plugin SDK Version
dify_plugin>=0.3.0,<0.5.0is in requirements.txt (SDK docs)Environment Verification
Local Deployment Environment
SaaS Environment