fix: stop thinking when use tool_calls.#222
fix: stop thinking when use tool_calls.#222jiangbo721 wants to merge 2 commits intolanggenius:mainfrom
Conversation
(cherry picked from commit 28cd815)
Summary of ChangesHello @jiangbo721, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves a bug where the large language model's internal "thinking" state was not properly concluded when Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a fix to ensure the <think> tag is properly closed when tool_calls are present in a streaming response. The logic in _wrap_thinking_by_reasoning_content is correctly updated to check for tool_calls in addition to content before exiting the 'thinking' state. The patch also includes a version bump in pyproject.toml, which is appropriate for this bug fix. The changes are correct and well-implemented.
close: #221
Pull Request Checklist
Thank you for your contribution! Before submitting your PR, please make sure you have completed the following checks:
Compatibility Check
README.mdREADME.mdREADME.mdREADME.mdAvailable Checks