Skip to content

hotfix: remove unexpected keyword param#294

Merged
Stream29 merged 1 commit intomainfrom
hotfix/unexpected-named-param
Mar 12, 2026
Merged

hotfix: remove unexpected keyword param#294
Stream29 merged 1 commit intomainfrom
hotfix/unexpected-named-param

Conversation

@Stream29
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a hotfix by removing an unexpected keyword argument that was causing issues in the dify_plugin. Concurrently, the project's version has been updated to reflect this change and prepare for a new release.

Highlights

  • Keyword Argument Removal: The httpx_timeout keyword argument was removed from the _execute_request function call in plugin.py, addressing an unexpected parameter issue.
  • Version Bump: The project version in pyproject.toml has been incremented from 0.7.3 to 0.7.4.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • python/dify_plugin/plugin.py
    • Removed the httpx_timeout keyword argument from the _execute_request function call.
  • python/pyproject.toml
    • Updated the project version from 0.7.3 to 0.7.4.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a hotfix by removing an unexpected keyword parameter, httpx_timeout, from a function call in python/dify_plugin/plugin.py, which resolves a TypeError. The package version in pyproject.toml is also incremented accordingly. While the fix is correct, it leaves the HTTPX_TIMEOUT configuration value unused, causing related HTTP requests to default to a potentially long timeout period. I have added a comment to highlight this for future consideration.

endpoint_id=endpoint_id,
context=context,
max_invocation_timeout=self.config.MAX_INVOCATION_TIMEOUT,
httpx_timeout=self.config.HTTPX_TIMEOUT,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While removing this parameter correctly fixes the TypeError (as Session.__init__ does not accept httpx_timeout), it's worth noting that the HTTPX_TIMEOUT configuration value is now unused. Consequently, the httpx calls in _http_backwards_invoke will use max_invocation_timeout (defaulting to 250s), which may be an unexpectedly long timeout for an HTTP request. This could be addressed in a future change to ensure timeouts are configured as intended.

@Stream29 Stream29 merged commit 7b79a99 into main Mar 12, 2026
3 checks passed
@Stream29 Stream29 deleted the hotfix/unexpected-named-param branch March 12, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants