Skip to content

refactor(web): simplify the tool category filter component - #40242

Draft
lyzno1 wants to merge 1 commit into
mainfrom
codex/refactor-tab-filter-component
Draft

refactor(web): simplify the tool category filter component#40242
lyzno1 wants to merge 1 commit into
mainfrom
codex/refactor-tab-filter-component

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the legacy React.FC declaration with a named function
  • import ReactNode directly for the option icon type
  • keep the tool category filter's public behavior and rendered DOM unchanged

Scope

Only web/app/components/base/tab-slider-new/index.tsx.

This is a mechanical preparation layer. It does not change props, classes, handlers, test ids, or output.

Verification

  • pnpm exec vp test run app/components/base/tab-slider-new/__tests__/index.spec.tsx — 1/1
  • pnpm check — 0 errors, existing warnings only
  • git diff --check

Visual regression

None: the generated JSX and class names are unchanged.

Stack

Base: main

Child: #40243 adds the semantic filter behavior. Review and revert this PR independently; if reverting the complete stack, start from the top child.

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.42%. Comparing base (e036075) to head (102f045).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #40242   +/-   ##
=======================================
  Coverage   86.41%   86.42%           
=======================================
  Files        5107     5107           
  Lines      290731   290749   +18     
  Branches    57917    57923    +6     
=======================================
+ Hits       251245   251267   +22     
+ Misses      34545    34541    -4     
  Partials     4941     4941           
Flag Coverage Δ
dify-ui 93.49% <ø> (ø)
web 86.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant