Skip to content

refactor(web): use css icons in the tab filter story - #40244

Closed
lyzno1 wants to merge 1 commit into
codex/a11y-tool-category-filterfrom
codex/refactor-tab-filter-story-icons
Closed

refactor(web): use css icons in the tab filter story#40244
lyzno1 wants to merge 1 commit into
codex/a11y-tool-category-filterfrom
codex/refactor-tab-filter-story-icons

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • replace two Remix React icons in the TabSliderNew story with the repository's recommended CSS icon classes
  • mark the decorative story icons hidden from assistive technology
  • remove the two focused icon warnings without touching production code

Scope

Only web/app/components/base/tab-slider-new/index.stories.tsx.

This layer has no production bundle or runtime behavior change.

Visual regression

Compared this story against #40243 with the same viewport and theme.

  • both icons remain 16 × 16
  • both icons retain the same x/y coordinates, 8 px right margin, and colors
  • both item boxes and both text ranges remain unchanged
  • the CSS masks use the corresponding Remix icon data recommended by the repository lint rule

Verification

  • pnpm exec vp check app/components/base/tab-slider-new/index.stories.tsx — 0 warnings/errors
  • pnpm check — 0 errors; repository warning count decreases by 2
  • git diff --check

Stack

Base: #40243

This is the final, Storybook-only layer of stack #40245. It can be omitted or reverted without affecting the accessibility fix.

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (codex/a11y-tool-category-filter@863bf36). Learn more about missing BASE report.

Additional details and impacted files
@@                        Coverage Diff                         @@
##             codex/a11y-tool-category-filter   #40244   +/-   ##
==================================================================
  Coverage                                   ?   86.41%           
==================================================================
  Files                                      ?     5107           
  Lines                                      ?   290733           
  Branches                                   ?    57916           
==================================================================
  Hits                                       ?   251247           
  Misses                                     ?    34545           
  Partials                                   ?     4941           
Flag Coverage Δ
dify-ui 93.49% <ø> (?)
web 86.10% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1

lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

Closing during the accessibility stack audit. This layer only changes component typing or icon implementation, adds no user-visible accessibility contract, and carries independent visual/review risk. It can be reconsidered later as a separate cleanup, not as an a11y dependency.

@lyzno1 lyzno1 closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant