refactor(web): use css icons in the tab filter story - #40244
Closed
lyzno1 wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## codex/a11y-tool-category-filter #40244 +/- ##
==================================================================
Coverage ? 86.41%
==================================================================
Files ? 5107
Lines ? 290733
Branches ? 57916
==================================================================
Hits ? 251247
Misses ? 34545
Partials ? 4941
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Closing during the accessibility stack audit. This layer only changes component typing or icon implementation, adds no user-visible accessibility contract, and carries independent visual/review risk. It can be reconsidered later as a separate cleanup, not as an a11y dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
Only
web/app/components/base/tab-slider-new/index.stories.tsx.This layer has no production bundle or runtime behavior change.
Visual regression
Compared this story against #40243 with the same viewport and theme.
Verification
pnpm exec vp check app/components/base/tab-slider-new/index.stories.tsx— 0 warnings/errorspnpm check— 0 errors; repository warning count decreases by 2git diff --checkStack
Base: #40243
This is the final, Storybook-only layer of stack #40245. It can be omitted or reverted without affecting the accessibility fix.