Skip to content

fix(web): name the embedded chat settings trigger - #40250

Draft
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-embedded-chat-settings-trigger
Draft

fix(web): name the embedded chat settings trigger#40250
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-embedded-chat-settings-trigger

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Give the embedded chat settings trigger the same translated accessible name shown in its panel heading.
  • Mark the CSS chat-settings icon as decorative.
  • Exercise the trigger through its public button role and accessible name instead of relying on data-testid.

Behavior contract

  • Assistive technology exposes the icon-only trigger as the chat settings action.
  • Pointer activation still opens and closes the existing popover.
  • The existing test ID remains available; this PR changes the test contract without treating test IDs as accessibility defects.

Visual regression review

This is an ARIA-only change. No element tag, class, style, text node, node order, popover geometry, or interaction state changed, so no visual delta is expected.

Validation

  • pnpm exec vp check app/components/base/chat/embedded-chatbot/inputs-form/view-form-dropdown.tsx app/components/base/chat/embedded-chatbot/inputs-form/__tests__/view-form-dropdown.spec.tsx
  • node scripts/lint-a11y.mjs app/components/base/chat/embedded-chatbot/inputs-form/view-form-dropdown.tsx
  • pnpm exec vp test run app/components/base/chat/embedded-chatbot/inputs-form/__tests__/view-form-dropdown.spec.tsx (1/1)
  • pnpm check (0 errors; 2059 existing warnings)

From Codex

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.41%. Comparing base (e036075) to head (9b2ef69).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #40250   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files        5107     5107           
  Lines      290731   290750   +19     
  Branches    57917    57923    +6     
=======================================
+ Hits       251245   251265   +20     
+ Misses      34545    34544    -1     
  Partials     4941     4941           
Flag Coverage Δ
dify-ui 93.49% <ø> (ø)
web 86.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant