Skip to content

fix(web): name the snippet info menu trigger - #40251

Draft
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-snippet-info-menu-trigger
Draft

fix(web): name the snippet info menu trigger#40251
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-snippet-info-menu-trigger

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Give the snippet sidebar overflow trigger the established translated common.operation.more accessible name.
  • Exercise every edit, export, and delete flow through the named trigger instead of an anonymous button query.

Behavior contract

  • Assistive technology exposes the icon-only trigger as the More action.
  • Existing permission filtering and edit, export, and delete behavior remain unchanged.
  • The label matches the snippet card, dataset sidebar, MCP detail, and other existing overflow-menu contracts.

Visual regression review

This is an ARIA-only production change. No element tag, class, style, icon, node order, popup placement, or interaction state changed, so no visual delta is expected.

Validation

  • pnpm exec vp check app/components/app-sidebar/snippet-info/dropdown.tsx app/components/app-sidebar/snippet-info/__tests__/dropdown.spec.tsx
  • node scripts/lint-a11y.mjs app/components/app-sidebar/snippet-info/dropdown.tsx
  • pnpm exec vp test run app/components/app-sidebar/snippet-info/__tests__/dropdown.spec.tsx (7/7)
  • pnpm check (0 errors; 2059 existing warnings)

From Codex

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.42%. Comparing base (e036075) to head (4f37533).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #40251   +/-   ##
=======================================
  Coverage   86.41%   86.42%           
=======================================
  Files        5107     5107           
  Lines      290731   290750   +19     
  Branches    57917    57923    +6     
=======================================
+ Hits       251245   251271   +26     
+ Misses      34545    34538    -7     
  Partials     4941     4941           
Flag Coverage Δ
dify-ui 93.49% <ø> (ø)
web 86.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant