Skip to content

fix(web): name the plugin debug trigger - #40252

Draft
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-plugin-debug-trigger
Draft

fix(web): name the plugin debug trigger#40252
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-plugin-debug-trigger

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Reuse the plugin debug panel title as the accessible name of both the available and unavailable debug triggers.
  • Exercise the enabled and disabled states through the public button role and accessible name.
  • Keep the sidebar consumer and default icon trigger on one shared label contract.

Behavior contract

  • The default bug-icon button is announced as the plugin debug action.
  • The unavailable state remains disabled while retaining its accessible name.
  • The available state opens the same popover and exposes the same title, port, masked key, and documentation link.

Visual regression review

This is an ARIA-only rendered change plus reuse of the existing title string. No tag, class, style, icon, visible text, node order, popover geometry, or state styling changed, so no visual delta is expected.

Validation

  • pnpm exec vp check app/components/plugins/plugin-page/debug-info.tsx app/components/plugins/plugin-page/__tests__/debug-info.spec.tsx
  • node scripts/lint-a11y.mjs app/components/plugins/plugin-page/debug-info.tsx
  • pnpm exec vp test run app/components/plugins/plugin-page/__tests__/debug-info.spec.tsx (3/3)
  • pnpm check (0 errors; 2059 existing warnings)

From Codex

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.42%. Comparing base (e036075) to head (50148f0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #40252   +/-   ##
=======================================
  Coverage   86.41%   86.42%           
=======================================
  Files        5107     5107           
  Lines      290731   290749   +18     
  Branches    57917    57923    +6     
=======================================
+ Hits       251245   251267   +22     
+ Misses      34545    34541    -4     
  Partials     4941     4941           
Flag Coverage Δ
dify-ui 93.49% <ø> (ø)
web 86.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant