Skip to content

fix(web): name annotation configuration action - #40255

Draft
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-annotation-config-action
Draft

fix(web): name annotation configuration action#40255
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-annotation-config-action

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Give the icon-only annotation reply setup action an explicit accessible name using the existing localized modal title.
  • Hide the equalizer icon from the accessibility tree because the button now owns the semantics.
  • Replace the owner test's CSS-class lookup with a role-and-name query.

Behavior contract

  • Assistive technology identifies the action as Annotation Reply Setup.
  • Activating the action still opens the existing configuration modal.
  • The existing save, close, selection, and annotation-list flows remain covered by the owner suite.

Visual regression

No visual change is expected. This PR does not change elements, classes, styles, layout, node order, or event handlers; it only adds ARIA attributes and strengthens one test query.

The existing icon migration warning and the annotation owner's existing data-flow lint debt are intentionally left unchanged so they can be reviewed separately.

Validation

  • node scripts/lint-a11y.mjs app/components/app/annotation/index.tsx
  • pnpm exec vp test run app/components/app/annotation/tests/index.spec.tsx (9/9)
  • pnpm check (0 errors, 2059 existing warnings)

The narrow file-only lint command also reports six pre-existing baseline errors in the annotation owner; this PR introduces none of those diagnostics.

From Codex

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.42%. Comparing base (e036075) to head (4de28d3).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #40255   +/-   ##
=======================================
  Coverage   86.41%   86.42%           
=======================================
  Files        5107     5107           
  Lines      290731   290750   +19     
  Branches    57917    57923    +6     
=======================================
+ Hits       251245   251268   +23     
+ Misses      34545    34541    -4     
  Partials     4941     4941           
Flag Coverage Δ
dify-ui 93.49% <ø> (ø)
web 86.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant