Skip to content

fix(web): name saved item actions - #40256

Draft
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-saved-item-actions
Draft

fix(web): name saved item actions#40256
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-saved-item-actions

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Give the saved text copy and delete icon buttons explicit accessible names.
  • Hide their Remix icons from the accessibility tree because the buttons now own the semantics.
  • Replace CSS-class and DOM-order test lookups with role-and-name queries.

Behavior contract

  • Assistive technology identifies the saved-item actions as Copy and Delete.
  • Copy still writes the answer and shows the existing success toast.
  • Delete still invokes the owner callback with the saved item ID.
  • The text-to-speech action remains independent and unchanged.

Visual regression

No visual change is expected. This PR does not change elements, classes, styles, layout, node order, or event handlers; it only adds ARIA attributes and strengthens test queries.

The two existing prefer-tailwind-icons warnings are intentionally left unchanged so icon implementation can be reviewed separately.

Validation

  • pnpm exec vp check app/components/app/text-generate/saved-items/index.tsx app/components/app/text-generate/saved-items/tests/index.spec.tsx (0 errors, 2 existing icon warnings)
  • node scripts/lint-a11y.mjs app/components/app/text-generate/saved-items/index.tsx
  • pnpm exec vp test run app/components/app/text-generate/saved-items/tests/index.spec.tsx (2/2)
  • pnpm check (0 errors, 2059 existing warnings)

From Codex

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.42%. Comparing base (e036075) to head (4c9b86d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #40256   +/-   ##
=======================================
  Coverage   86.41%   86.42%           
=======================================
  Files        5107     5107           
  Lines      290731   290751   +20     
  Branches    57917    57923    +6     
=======================================
+ Hits       251245   251269   +24     
+ Misses      34545    34541    -4     
  Partials     4941     4941           
Flag Coverage Δ
dify-ui 93.49% <ø> (ø)
web 86.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant