Skip to content

test(web): query credential coverage actions by name - #40268

Closed
lyzno1 wants to merge 1 commit into
codex/a11y-plugin-credential-action-testsfrom
codex/a11y-plugin-credential-coverage-tests
Closed

test(web): query credential coverage actions by name#40268
lyzno1 wants to merge 1 commit into
codex/a11y-plugin-credential-action-testsfrom
codex/a11y-plugin-credential-coverage-tests

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Replace the remaining concurrent and additional-coverage credential action entry locators with role-and-name queries.
  • Remove hidden-button traversal, SVG inspection, and conditional fallbacks that allowed coverage tests to skip the intended action.
  • Delete one outside-click test that was proven to be a no-op because its overlay selector never matched the rendered dialog.

Behavior contract

Visual regression

This is a test-only PR. It has no production bundle, DOM, CSS, layout, interaction, or runtime visual effect.

Validation

  • pnpm exec vp check app/components/plugins/plugin-auth/authorized/tests/index.spec.tsx (0 errors, 0 warnings)
  • pnpm exec vp test run app/components/plugins/plugin-auth/authorized/tests/index.spec.tsx (61/61)
  • pnpm check (0 errors, 2059 existing warnings)
  • No remaining Rename, Edit, or Delete SVG-class locators or hidden-action-button traversal in this spec.
  • git diff codex/a11y-plugin-credential-action-tests --stat (1 test file; 222 insertions, 685 deletions)

From Codex

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (codex/a11y-plugin-credential-action-tests@fecfc6e). Learn more about missing BASE report.

Additional details and impacted files
@@                             Coverage Diff                              @@
##             codex/a11y-plugin-credential-action-tests   #40268   +/-   ##
============================================================================
  Coverage                                             ?   86.42%           
============================================================================
  Files                                                ?     5107           
  Lines                                                ?   290752           
  Branches                                             ?    57923           
============================================================================
  Hits                                                 ?   251290           
  Misses                                               ?    34521           
  Partials                                             ?     4941           
Flag Coverage Δ
dify-ui 93.49% <ø> (?)
web 86.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1

lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

Closing during the test audit. This continues a split cleanup of the same oversized spec without adding a distinct behavior contract, and still leaves substantial duplicated/private-implementation coverage.

@lyzno1 lyzno1 closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant