refactor(web): use css icon for generated result copy - #40279
Draft
lyzno1 wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## codex/a11y-generated-result-copy #40279 +/- ##
====================================================================
- Coverage 86.42% 86.41% -0.01%
====================================================================
Files 5107 5107
Lines 290750 290732 -18
Branches 57923 57917 -6
====================================================================
- Hits 251271 251243 -28
- Misses 34538 34548 +10
Partials 4941 4941
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
i-ri-clipboard-lineCSS icon.@remixicon/reactimport.Dependency
This PR is stacked on #40259 because both layers intentionally modify the same copy action. The parent owns accessibility semantics; this child owns only icon implementation.
Behavior contract
Visual regression
This PR intentionally changes only the icon rendering implementation. The button element, padding, dimensions, color class, placement, handler, and surrounding layout are unchanged. The CSS icon uses the exact
i-ri-clipboard-linemapping required by the repository lint rule and is already used by other 16px copy actions in the codebase.Reviewer focus: compare the 16x16 clipboard silhouette, optical centering, color, button padding, and alignment with Apply in light and dark themes. No layout shift or ordinary-state difference is acceptable.
Validation
pnpm exec vp check app/components/app/configuration/config/automatic/result.tsx app/components/app/configuration/config/automatic/__tests__/result.spec.tsx(0 warnings, 0 errors; parent had 1 icon warning)pnpm lint:a11y app/components/app/configuration/config/automatic/result.tsx(0 diagnostics)pnpm exec vp test run app/components/app/configuration/config/automatic/__tests__/result.spec.tsx(3/3)pnpm check(0 errors, 2058 warnings; exactly one fewer than fix(web): name generated result copy action #40259)git diff codex/a11y-generated-result-copy --stat(1 production file; 1 insertion, 2 deletions)From Codex