Skip to content

refactor(web): use css icon for generated result copy - #40279

Draft
lyzno1 wants to merge 1 commit into
codex/a11y-generated-result-copyfrom
codex/refactor-generated-result-css-icon
Draft

refactor(web): use css icon for generated result copy#40279
lyzno1 wants to merge 1 commit into
codex/a11y-generated-result-copyfrom
codex/refactor-generated-result-css-icon

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Replace the generated-result copy action Remix React SVG with the lint-recommended i-ri-clipboard-line CSS icon.
  • Remove the now-unused @remixicon/react import.
  • Preserve the accessible name and decorative icon contract introduced by fix(web): name generated result copy action #40259.

Dependency

This PR is stacked on #40259 because both layers intentionally modify the same copy action. The parent owns accessibility semantics; this child owns only icon implementation.

Behavior contract

  • Copy still invokes the same clipboard and success-toast behavior.
  • The button accessible name remains Copy.
  • The icon remains decorative and exposes no separate accessibility node.

Visual regression

This PR intentionally changes only the icon rendering implementation. The button element, padding, dimensions, color class, placement, handler, and surrounding layout are unchanged. The CSS icon uses the exact i-ri-clipboard-line mapping required by the repository lint rule and is already used by other 16px copy actions in the codebase.

Reviewer focus: compare the 16x16 clipboard silhouette, optical centering, color, button padding, and alignment with Apply in light and dark themes. No layout shift or ordinary-state difference is acceptable.

Validation

  • pnpm exec vp check app/components/app/configuration/config/automatic/result.tsx app/components/app/configuration/config/automatic/__tests__/result.spec.tsx (0 warnings, 0 errors; parent had 1 icon warning)
  • pnpm lint:a11y app/components/app/configuration/config/automatic/result.tsx (0 diagnostics)
  • pnpm exec vp test run app/components/app/configuration/config/automatic/__tests__/result.spec.tsx (3/3)
  • pnpm check (0 errors, 2058 warnings; exactly one fewer than fix(web): name generated result copy action #40259)
  • git diff codex/a11y-generated-result-copy --stat (1 production file; 1 insertion, 2 deletions)

From Codex

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.41%. Comparing base (e008479) to head (a214c48).

Additional details and impacted files
@@                         Coverage Diff                          @@
##           codex/a11y-generated-result-copy   #40279      +/-   ##
====================================================================
- Coverage                             86.42%   86.41%   -0.01%     
====================================================================
  Files                                  5107     5107              
  Lines                                290750   290732      -18     
  Branches                              57923    57917       -6     
====================================================================
- Hits                                 251271   251243      -28     
- Misses                                34538    34548      +10     
  Partials                               4941     4941              
Flag Coverage Δ
dify-ui 93.49% <ø> (ø)
web 86.10% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant