fix: remove sshfs reference and timeout dependency for macOS#3
Open
FrancisBehnen wants to merge 2 commits into
Open
fix: remove sshfs reference and timeout dependency for macOS#3FrancisBehnen wants to merge 2 commits into
FrancisBehnen wants to merge 2 commits into
Conversation
The project uses Mutagen for file sync, not SSHFS. The dependency check was outdated and also only suggested Homebrew for installation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
macOS does not ship with the `timeout` command (it's part of GNU coreutils). On machines without it, `is_remote_available()` always fails because `timeout` exits with "command not found", causing every command to fall back to local execution silently. Replace `timeout N ssh ...` with SSH's built-in `-o ConnectTimeout=N`, which provides the same protection without requiring coreutils.
FrancisBehnen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for macOS compatibility:
timeoutcommand dependency — macOS doesn't ship GNU coreutils, sois_remote_available()always failed silently, causing all commands to fall back to local execution instead of the remote serverChanges
setup.sh: Check formutageninstead ofsshfs, suggest both Homebrew and MacPortsscripts/remote-shell.sh: Replacetimeout N ssh ...with SSH's built-in-o ConnectTimeout=NTest plan
setup.shcorrectly detects mutagenremote-shell.shconnects to remote withouttimeoutbinaryis_remote_available()returns true when remote is reachable