Skip to content

Update app/scripts/cmake_build.sh#311

Open
steven-t-walton wants to merge 1 commit intomainfrom
steven-t-walton-patch-1
Open

Update app/scripts/cmake_build.sh#311
steven-t-walton wants to merge 1 commit intomainfrom
steven-t-walton-patch-1

Conversation

@steven-t-walton
Copy link
Collaborator

Description

In app/scripts/cmake_build.sh fixed SGH_BUILD_CORES to FIERRO_BUILD_CORES:-1 since SGH_BUILD_CORES is not a cmake variable and we will now default to 1 core if FIERRO_BUILD_CORES is not set for some reason.

Type of change

Please select all relevant options

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Formatting and/or style fixes
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Successful build on personal linux machine.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code builds from scratch with my new changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

In app/scripts/cmake_build.sh fixed SGH_BUILD_CORES to FIERRO_BUILD_CORES:-1 since SGH_BUILD_CORES is not a cmake variable and we default to 1 core if FIERRO_BUILD_CORES is not set for some reason.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants