Open
Conversation
…he LLF face fluxes. Only do mhd fluxes for n=0 species. Add a divB diagnostic variable.
…e cell field from the face field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This adds ideal MHD. It should work with AMR and all coordinate systems. I have tested on the magnetized blast problem in cartesian/cylindrical coordinates with/without AMR (modified the existing pgen), the Orszag-Tang vortex (new pgen), and the Brio-Wu shock tube (new input file).
The outline of new features/changed things:
Overall, it's not too many new things and there isn't much in the input file that needed to change.
Some things I'm not too happy with that we might want to change:
This was done in concert with GPT.
I haven't tested on GPUs yet or anything high res. Initial testing looks pretty good though, I added a diagnostic div(B) field at that remains at machine epsilon even through AMR in cylindrical/cartesian coordinates.
Description of Changes
Closes #122
Checklist
// This file was created in part or in whole by generative AI