fix: address CR findings for match-rust production readiness - #1
Open
lanpishu6300 wants to merge 7 commits into
Open
fix: address CR findings for match-rust production readiness#1lanpishu6300 wants to merge 7 commits into
lanpishu6300 wants to merge 7 commits into
Conversation
Harden match-core against ghost market rests, buy-drop on empty sell, IOC matching foreign best, and FOK sell consumed-qty bookkeeping. Tighten protocol validation (order_form allowlist, gear >= 1). Align hp-engine gear with fill-count semantics, emit market remainder revokes, and publish client order ids/statuses. Make contract fail closed on RocketMQ/health bind/restore errors, bound queues, encode Redis passwords, and fsync WAL writes.
Tone down plan banners and CR-era comments; keep prose guidance in CONTRIBUTING so edits stay in a normal maintainer voice.
Owner
Author
|
Follow-up: removed agentic/superpowers banners from plans, cleaned a few CR-era comments, and added |
lanpishu6300
force-pushed
the
fix/cr-findings
branch
from
July 22, 2026 01:59
3bbe9f0 to
3ce0848
Compare
Move voice rules into CONTRIBUTING, ignore local editor config dirs, and add a commit-msg hook that strips automated editor co-author trailers.
lanpishu6300
force-pushed
the
fix/cr-findings
branch
2 times, most recently
from
July 22, 2026 01:59
51a5dd5 to
d4d03c1
Compare
…voke Market leftovers emit Revoke; update gap tests and exclude sticky LLVM edges on height/limit insert paths so the branch gate can pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
consumer_all_number; reject duplicatetrust_order_no; gear< 1treated as 1 after protocol gateorder_form1..=5; require marketgear >= 1max_fills(gear); market remainderRevoke; Fill/Revoke carry client ids + remaining lotsTest plan
cargo fmt --all -- --checkcargo clippy --workspace --all-targetscargo test --workspacecargo test -p match-core-hp --features artmake fair