eslint-plugin-storybookがインストールされているのに効いてなかったので有効化#299
Open
eslint-plugin-storybookがインストールされているのに効いてなかったので有効化#299
Conversation
Contributor
Masa-Shin
commented
Sep 4, 2025
Masa-Shin
commented
- eslint-plugin-storybookを有効化
- commitlintの100文字制限は意味がわからないので無効化
- Storybookをマイナーアップデート
Masa-Shin
force-pushed
the
0/feature/enable-eslint-plugin-storybook
branch
2 times, most recently
from
4a3e056 to
dc4e3a5
Compare
Masa-Shin
commented
Sep 5, 2025
| @@ -0,0 +1 @@ | |||
| !.storybook | |||
Masa-Shin
commented
Sep 5, 2025
| "@storybook/core": "^8.3.5", | ||
| "@storybook/vue3-vite": "^8.3.5", | ||
| "@types/body-scroll-lock": "^3.1.2", | ||
| "@types/eslint__js": "^8.42.3", |
Contributor
Author
There was a problem hiding this comment.
型は@eslint/jsに入ってるので不要
https://www.npmjs.com/package/@types/eslint__js
Masa-Shin
commented
Sep 5, 2025
| "extends": [ | ||
| "plugin:storybook/recommended" | ||
| ] | ||
| }, |
Masa-Shin
commented
Sep 5, 2025
| rules: { | ||
| 'body-max-line-length': [0, 'always'] | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
commitの説明に参考URLを貼っただけで100文字は超過するのと、そもそもcommitに文字数制限は別にいらんやろと言うことで切りました
Masa-Shin
commented
Sep 5, 2025
| @@ -1,4 +1,4 @@ | |||
| import type { Preview } from '@storybook/vue3' | |||
| import type { Preview } from '@storybook/vue3-vite' | |||
Masa-Shin
commented
Sep 5, 2025
| "eslint-config-prettier": "^9.1.0", | ||
| "eslint-plugin-prettier": "^5.2.1", | ||
| "eslint-plugin-storybook": "9.1.4", | ||
| "eslint-plugin-storybook": "^0.11.6", |
tktcorporation
force-pushed
the
0/feature/enable-eslint-plugin-storybook
branch
from
dc4e3a5 to
47da08c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.