Skip to content

feat(lark-contact): route user_profiles batch_query in skill#1164

Open
liangshuo-1 wants to merge 1 commit into
mainfrom
feat/contact-add-user-profiles-batch-query
Open

feat(lark-contact): route user_profiles batch_query in skill#1164
liangshuo-1 wants to merge 1 commit into
mainfrom
feat/contact-add-user-profiles-batch-query

Conversation

@liangshuo-1
Copy link
Copy Markdown
Collaborator

@liangshuo-1 liangshuo-1 commented May 28, 2026

Summary

Add user_profiles batch_query to the lark-contact skill so the agent can fetch personal status and signature via the native API.

  • Add a row to the routing table for user_profiles batch_query (user identity only).
  • Add a worked example next to the existing +search-user flow.
  • Mention personal status / signature in the skill description so routing picks up these queries.

Test plan

  • lark-cli schema contact.user_profiles.batch_query matches the --data / --params shape used in the example.
  • With profile:user_profile:read granted on a user identity, the example command returns user_profiles[] with personal_status and description.

- Add user_profiles batch_query row to the routing table.
- Add a worked example next to the search-user one, with `lark-cli
  schema` first (best practice: don't guess `--data` / `--params`).
- Trim description: drop the duplicated trigger clause, add
  personal_status / signature to the capability list so routing picks
  this skill up for those queries.

Change-Id: Ib32c56f6a389b3c248409228f4c7461453d1dcd3
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

📝 Walkthrough

Walkthrough

Documentation updates to the lark-contact skill that clarify its purpose, add a batch-query use-case example with CLI parameters, and refine scope boundaries. No code or exported entities changed.

Changes

lark-contact Skill Documentation

Layer / File(s) Summary
Skill description and batch-query documentation
skills/lark-contact/SKILL.md
Updated skill description clarifies parsing contacts to open_id and reverse-lookup use cases. Extended command-selection table with a new row for batch personal status/signature queries and added "典型场景" section with contact.user_profiles.batch_query example commands and CLI parameters.
Scope clarification
skills/lark-contact/SKILL.md
Refined formatting of the "不在本 skill 范围" bullet describing department tree, employee listing, and organization chart lookup exclusions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

📖 A skill grows clearer with words refined,
New examples guide the way,
Batch queries dance in scope aligned,
Lark docs shine brighter today! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description covers Summary and Test Plan sections, but lacks a structured Changes list and Related Issues section per template. Reformulate the description to match the template structure: add a bulleted Changes section, include the Related Issues section, and use the standard test checklist format with checkboxes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: routing a batch_query endpoint for user_profiles into the lark-contact skill's command-selection table.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/contact-add-user-profiles-batch-query

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added domain/contact PR touches the contact domain size/M Single-domain feat or fix with limited business impact labels May 28, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@github-actions
Copy link
Copy Markdown

🚀 PR Preview Install Guide

🧰 CLI update

npm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@296b34a5014b135cc3af4a4e83895634d43a2330

🧩 Skill update

npx skills add larksuite/cli#feat/contact-add-user-profiles-batch-query -y -g

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.77%. Comparing base (a2cc5e1) to head (296b34a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1164   +/-   ##
=======================================
  Coverage   68.77%   68.77%           
=======================================
  Files         628      628           
  Lines       58670    58670           
=======================================
  Hits        40353    40353           
  Misses      15021    15021           
  Partials     3296     3296           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain/contact PR touches the contact domain size/M Single-domain feat or fix with limited business impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant