Skip to content

feat: add update skill sync scope flags#1189

Draft
nguyenngothuong wants to merge 1 commit into
larksuite:mainfrom
nguyenngothuong:codex/update-skill-sync-mode
Draft

feat: add update skill sync scope flags#1189
nguyenngothuong wants to merge 1 commit into
larksuite:mainfrom
nguyenngothuong:codex/update-skill-sync-mode

Conversation

@nguyenngothuong
Copy link
Copy Markdown

Summary

Add explicit update scope controls so users and automation can choose whether lark-cli update should also sync official Lark/Feishu skills. The default remains unchanged: lark-cli update still syncs skills unless --cli-only is passed.

Changes

  • Add lark-cli update --cli-only to update only the CLI package and skip skills sync.
  • Add lark-cli update --with-skills as an explicit form of the current default behavior.
  • Reject --cli-only --with-skills before network/update work starts.
  • Report skills_action: skipped in JSON output when skills sync is intentionally skipped.

Test Plan

  • Unit tests pass: go test ./cmd/update -run "TestUpdateNpm_CLIOnlySkipsSkillsSync_JSON|TestUpdateNpm_WithSkillsRunsSkillsSync_JSON|TestUpdateSkillSyncFlagsMutuallyExclusive" -count=1
  • Unit tests pass: go test ./cmd/update -count=1
  • Manual local verification confirms the lark-cli update flow works as expected

Related Issues

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 31, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: eed407d6-7a6e-4547-977b-fa8957a12659

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/L Large or sensitive change across domains or core paths label May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Large or sensitive change across domains or core paths

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants