Fix CREATE_SYSV_VALIST issue - #372
Open
sunny868 wants to merge 1 commit into
Open
Conversation
sunny868
commented
Aug 4, 2026
| @@ -76,7 +75,7 @@ typedef struct x64_va_list_s { | |||
| #endif | |||
|
|
|||
| #define VARARGS sysv_varargs | |||
| #define PREPARE_VALIST CREATE_SYSV_VALIST(__MY_R_RSP) | |||
| #define PREPARE_VALIST CREATE_SYSV_VALIST(cpu->scratch) | |||
Contributor
Author
|
从近期直通JVM的评估结果来看,类似这种的小修小补意义不大。只要是KZT开启,就存在libc内TLS数据割裂问题。以libc内线程局部数据locale为例: 同一个线程内运行x86和native函数: 就是所谓“双架构地址空间”引起的数据不一致。根本解决估计还得是libc api 全直通+外挂TLS,实际上box64就是这么干的。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 变更说明
直通libc中公共 printf 家族函数遇到变长参数转换错误,导致matlab测试失败。本patch做了修正。
Validation / 验证