feat(runtime): add safe secret input modes#75
Merged
Conversation
Signed-off-by: samzong <samzong.lu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--<flag>-env,--<flag>-file, or--<flag>-stdininstead of direct shell arguments.commands show --jsonviaflags[].input_modesand bump the catalog schema from 7 to 8.Closes #71.
Scope comparison
--input-api-key-env OPENAI_API_KEYand sibling modes work for generated sensitive string flags--input-api-key sk-...style flags still workformat: password; no new overlay/schema surfaceflags[].input_modes=[\"flag\",\"env\",\"file\",\"stdin\"]and catalog schema 8x-sensitivesensitivecontrol--setand--fileremain unchangedVerification
make checkCompatibility
format: password; those flags gain additional sibling safe-input flags while preserving the direct flag.commands show --jsonaddsflags[].input_modesfor sensitive flags, andcommands schema --jsonnow reports catalog schema version 8.Checklist
internal/generated/,.cache/, and ad-hocskills/<cli-name>/directories is not committed.