chore: Implement Synchronizer protocol for polling data source#345
Merged
chore: Implement Synchronizer protocol for polling data source#345
Conversation
🚨 Bugbot Trial ExpiredYour team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot. A team admin can activate the plan in the Cursor dashboard. |
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
kinyoklion
reviewed
Aug 11, 2025
| next(sync) | ||
| assert False, "Expected StopIteration" | ||
| except StopIteration: | ||
| pass No newline at end of file |
Member
There was a problem hiding this comment.
nit: Newline at end of file.
kinyoklion
approved these changes
Aug 11, 2025
| ) | ||
|
|
||
| if self._event.wait(self._poll_interval): | ||
| break |
There was a problem hiding this comment.
Bug: PollingDataSource Fails to Handle Exceptions and Retries Prematurely
The PollingDataSource.sync() method has two issues:
- It does not catch exceptions raised by
requester.fetch(). Network errors (e.g., timeouts, connection failures) will propagate, terminating the synchronizer generator instead of yielding anINTERRUPTEDorOFFUpdate. This can crash the polling process in production. - On recoverable HTTP errors,
sync()immediately retries without waiting for the configured poll interval. This creates a tight loop that can excessively hammer the polling endpoint and consume CPU.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.