feat: Update ChangeSet to always require a Selector#405
Merged
jsonbailey merged 9 commits intomainfrom Feb 4, 2026
Merged
Conversation
keelerm84
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
This is a type/contract change that affects how FDv2 updates are applied and when data is considered ready/persistable; downstream code assuming
selectorcan beNonemay break or change behavior.Overview
ChangeSet now always carries a
Selector(non-optional). This removesNonehandling throughout the FDv2 path and standardizes onSelector.no_selector()for “no selector” cases.Initializer/store logic is simplified accordingly: persistence and readiness gating now use
change_set.selector.is_defined()directly (noselector is not Nonechecks), andStore._set_basis/_apply_deltasignatures are tightened to require aSelector. Tests are updated to reflect the new invariant (selectors are always present; assertions now checkis_defined()instead ofis not None).Written by Cursor Bugbot for commit 57f5d00. This will update automatically on new commits. Configure here.