-
Notifications
You must be signed in to change notification settings - Fork 54
chore: Create FDv2 polling and fallback data source #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Matthew M. Keeler <mkeeler@launchdarkly.com>
keelerm84
reviewed
Jan 13, 2026
Member
keelerm84
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem okay to me, minus the bot feedback.
keelerm84
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Introduces the FDv2 polling data path with fallback signaling and supporting infrastructure.
Impl::DataSystem::PollingDataSource(Initializer/Synchronizer) with periodic fetch, recoverable/unrecoverable error handling,x-launchdarkly-env-idcapture, and FDv1 fallback viax-launchdarkly-fd-fallbackHTTPPollingRequester(FDv2/sdk/poll) andHTTPFDv1PollingRequester(FDv1/sdk/latest-all), with ETag handling, selector/filter query params, JSON parsing, and gracefulstoppolling_payload_to_changeset(FDv2 events) andfdv1_polling_payload_to_changeset(latest-all) producingChangeSetsDataSystemfactory methods now exposepolling_ds_builderandfdv1_fallback_ds_builder; default/streaming/polling configs wire them inResultnow carries optionalheaders;ChangeSetBuilder.no_changesusesSelector.no_selectorImpl::DataSource::PollingProcessornow stops requestor on shutdownWritten by Cursor Bugbot for commit c5ca138. This will update automatically on new commits. Configure here.