Skip to content

Conversation

@jsonbailey
Copy link
Contributor

@jsonbailey jsonbailey commented Jan 13, 2026

Note

Introduces the FDv2 polling data path with fallback signaling and supporting infrastructure.

  • New Impl::DataSystem::PollingDataSource (Initializer/Synchronizer) with periodic fetch, recoverable/unrecoverable error handling, x-launchdarkly-env-id capture, and FDv1 fallback via x-launchdarkly-fd-fallback
  • HTTP requesters: HTTPPollingRequester (FDv2 /sdk/poll) and HTTPFDv1PollingRequester (FDv1 /sdk/latest-all), with ETag handling, selector/filter query params, JSON parsing, and graceful stop
  • Payload parsing helpers: polling_payload_to_changeset (FDv2 events) and fdv1_polling_payload_to_changeset (latest-all) producing ChangeSets
  • DataSystem factory methods now expose polling_ds_builder and fdv1_fallback_ds_builder; default/streaming/polling configs wire them in
  • Result now carries optional headers; ChangeSetBuilder.no_changes uses Selector.no_selector
  • Legacy Impl::DataSource::PollingProcessor now stops requestor on shutdown
  • Extensive specs added for initializer/synchronizer behavior, header/fallback handling, and payload parsing

Written by Cursor Bugbot for commit c5ca138. This will update automatically on new commits. Configure here.

@jsonbailey jsonbailey requested a review from a team as a code owner January 13, 2026 06:36
Copy link
Member

@keelerm84 keelerm84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem okay to me, minus the bot feedback.

@jsonbailey jsonbailey requested a review from keelerm84 January 13, 2026 15:57
Base automatically changed from jb/sdk-1543/fdv2-test-data-source to main January 13, 2026 15:57
@jsonbailey jsonbailey changed the title chore: Create FDv2 and fallback polling data source chore: Create FDv2 polling and fallback data source Jan 13, 2026
@jsonbailey jsonbailey merged commit 488a90d into main Jan 20, 2026
10 checks passed
@jsonbailey jsonbailey deleted the jb/sdk-1544/fdv2-polling-data-source branch January 20, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants