fix: support strip UTF-8 BOM header #114
Open
+84
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #113 .
Description
According to #113 , the existing implementation of
event_parser.rsdoes not support stripping the UTF-8 BOM header. I fixed this by introducing a state machine (BomHeaderState) inEventParser. It buffers the initial data from the first message, strips BOM header if it exists, and passes the following data to the downstream parser.This may introduce an extra memory allocation at the beginning of the connection, but for the rest of the stream, the overhead is negligible (just a single if check).