fix(metadata): ingest new data and regenerate products#373
fix(metadata): ingest new data and regenerate products#373github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| "android": "Android SDK", | ||
| "apex-server-sdk": "Apex Server SDK", | ||
| "browser": "JavaScript Browser SDK", | ||
| "browser": "JavaScript Client SDK", |
There was a problem hiding this comment.
Duplicate display name for two distinct SDK IDs
Low Severity
Renaming browser from "JavaScript Browser SDK" to "JavaScript Client SDK" creates a duplicate display name — the existing js-client-sdk entry already has the name "JavaScript Client SDK". Two distinct SDK IDs now map to the same display name across all three copies of names.json, which could cause ambiguity in any downstream UI or service that displays or indexes SDKs by name.
Additional Locations (1)
| "react": { | ||
| "wrapperNames": [ | ||
| "react-client-sdk" | ||
| ] |
There was a problem hiding this comment.
Shared wrapper name shadows existing SDK lookup result
Medium Severity
The new react entry has wrapperNames: ["react-client-sdk"], identical to the existing react-client-sdk entry. Because GetSDKNameByWrapperOrUserAgent iterates alphabetically and react sorts before react-client-sdk, looking up the wrapper name "react-client-sdk" now returns "React SDK" instead of "React Web SDK". The react-client-sdk wrapper entry is effectively unreachable.
5145ab7 to
9e83cc2
Compare
|
The additions to the sdk_features table are what I expected. I'm not sure about the other items related to our javascript SDKs. @joker23 how does this look to you? |


Metadata has changed. Ensure that the changes obey patch semantics (data added or modified in a non-breaking
way), as upstream services may consume these changes automatically.
Note
Medium Risk
Primarily data-only metadata updates, but it removes/renames SDK identifiers (notably
combined-browserandreact-universal), which could break downstream consumers that reference those IDs.Overview
Regenerates SDK metadata and derived
api-js,api/sdkmeta, andproductsJSON datasets.This drops the
combined-browserSDK from feature/language/name/repo/type/user-agent catalogs, renames thebrowserdisplay name to JavaScript Client SDK, and replacesreact-universalwith a newreactSDK entry (new path/tag-prefix and wrapper mapping toreact-client-sdk).It also adds full feature capability matrices for
lua-server-sdkandnode-client-sdkinto the shared feature catalogs and the correspondingmetadata/launchdarkly_*.jsonsources.Written by Cursor Bugbot for commit 9e83cc2. This will update automatically on new commits. Configure here.